Messages in this thread | | | Subject | Re: [PATCH] brcmfmac: no need to check return value of debugfs_create functions | From | Kalle Valo <> | Date | Mon, 4 May 2020 09:50:42 +0000 (UTC) |
| |
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
> When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > In doing this, make brcmf_debugfs_add_entry() return void as no one was > even paying attention to the return value. > > Cc: Arend van Spriel <arend.vanspriel@broadcom.com> > Cc: Franky Lin <franky.lin@broadcom.com> > Cc: Hante Meuleman <hante.meuleman@broadcom.com> > Cc: Chi-Hsien Lin <chi-hsien.lin@cypress.com> > Cc: Wright Feng <wright.feng@cypress.com> > Cc: Kalle Valo <kvalo@codeaurora.org> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Pieter-Paul Giesberts <pieter-paul.giesberts@broadcom.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: "Rafał Miłecki" <rafal@milecki.pl> > Cc: linux-wireless@vger.kernel.org > Cc: brcm80211-dev-list.pdl@broadcom.com > Cc: brcm80211-dev-list@cypress.com > Cc: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Patch applied to wireless-drivers-next.git, thanks.
ea1b3bc6d5ad brcmfmac: no need to check return value of debugfs_create functions
-- https://patchwork.kernel.org/patch/11516617/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |