Messages in this thread | | | Subject | Re: [PATCH net v1] net: broadcom: fix a mistake about ioremap resource | From | Florian Fainelli <> | Date | Mon, 4 May 2020 20:28:52 -0700 |
| |
On 5/4/2020 7:03 PM, Dejin Zheng wrote: > Commit d7a5502b0bb8b ("net: broadcom: convert to > devm_platform_ioremap_resource_byname()") will broke this driver. > idm_base and nicpm_base were optional, after this change, they are > mandatory. it will probe fails with -22 when the dtb doesn't have them > defined. so revert part of this commit and make idm_base and nicpm_base > as optional. > > Fixes: d7a5502b0bb8bde ("net: broadcom: convert to devm_platform_ioremap_resource_byname()") > Reported-by: Jonathan Richardson <jonathan.richardson@broadcom.com> > Cc: Scott Branden <scott.branden@broadcom.com> > Cc: Ray Jui <ray.jui@broadcom.com> > Cc: Florian Fainelli <f.fainelli@gmail.com> > Cc: David S. Miller <davem@davemloft.net> > Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
Acked-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |