lkml.org 
[lkml]   [2020]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCHv2 02/10] net: eth: altera: set rx and tx ring size before init_dma call
    Date
    From: Dalon Westergreen <dalon.westergreen@intel.com>

    It is more appropriate to set the rx and tx ring size before calling
    the init function for the dma.

    Signed-off-by: Dalon Westergreen <dalon.westergreen@intel.com>
    Signed-off-by: Joyce Ooi <joyce.ooi@intel.com>
    ---
    v2: no change
    ---
    drivers/net/ethernet/altera/altera_tse_main.c | 6 ++++--
    1 file changed, 4 insertions(+), 2 deletions(-)

    diff --git a/drivers/net/ethernet/altera/altera_tse_main.c b/drivers/net/ethernet/altera/altera_tse_main.c
    index 2a9e6157a8a1..539e744e23f7 100644
    --- a/drivers/net/ethernet/altera/altera_tse_main.c
    +++ b/drivers/net/ethernet/altera/altera_tse_main.c
    @@ -1154,6 +1154,10 @@ static int tse_open(struct net_device *dev)
    int i;
    unsigned long int flags;

    + /* set tx and rx ring size */
    + priv->rx_ring_size = dma_rx_num;
    + priv->tx_ring_size = dma_tx_num;
    +
    /* Reset and configure TSE MAC and probe associated PHY */
    ret = priv->dmaops->init_dma(priv);
    if (ret != 0) {
    @@ -1196,8 +1200,6 @@ static int tse_open(struct net_device *dev)
    priv->dmaops->reset_dma(priv);

    /* Create and initialize the TX/RX descriptors chains. */
    - priv->rx_ring_size = dma_rx_num;
    - priv->tx_ring_size = dma_tx_num;
    ret = alloc_init_skbufs(priv);
    if (ret) {
    netdev_err(dev, "DMA descriptors initialization failed\n");
    --
    2.13.0
    \
     
     \ /
      Last update: 2020-05-04 10:28    [W:2.241 / U:0.448 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site