Messages in this thread | | | Date | Tue, 5 May 2020 03:11:58 +0800 | From | kbuild test robot <> | Subject | Re: [PATCH v3 2/2] sched: Add a check for cpu unbound deferrable timers |
| |
Hi Prasad,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/timers/core] [also build test ERROR on tip/auto-latest tip/timers/nohz v5.7-rc4 next-20200501] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Prasad-Sodagudi/timer-make-deferrable-cpu-unbound-timers-really-not-bound-to-a-cpu/20200503-025049 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 4479730e9263befbb9ce9563a09563db2acb8f7c config: riscv-nommu_virt_defconfig (attached as .config) compiler: riscv64-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
kernel/time/timer.c: In function 'get_timer_cpu_base': kernel/time/timer.c:848:11: error: 'timer_base_deferrable' undeclared (first use in this function) 848 | base = &timer_base_deferrable; | ^~~~~~~~~~~~~~~~~~~~~ kernel/time/timer.c:848:11: note: each undeclared identifier is reported only once for each function it appears in kernel/time/timer.c: In function 'get_timer_this_cpu_base': kernel/time/timer.c:867:11: error: 'timer_base_deferrable' undeclared (first use in this function) 867 | base = &timer_base_deferrable; | ^~~~~~~~~~~~~~~~~~~~~ kernel/time/timer.c: In function 'run_timer_softirq': >> kernel/time/timer.c:1829:24: error: 'deferrable_pending' undeclared (first use in this function) 1829 | if ((atomic_cmpxchg(&deferrable_pending, 1, 0) && | ^~~~~~~~~~~~~~~~~~ kernel/time/timer.c:1832:18: error: 'timer_base_deferrable' undeclared (first use in this function) 1832 | __run_timers(&timer_base_deferrable); | ^~~~~~~~~~~~~~~~~~~~~
vim +/deferrable_pending +1829 kernel/time/timer.c
1817 1818 /* 1819 * This function runs timers and the timer-tq in bottom half context. 1820 */ 1821 static __latent_entropy void run_timer_softirq(struct softirq_action *h) 1822 { 1823 struct timer_base *base = this_cpu_ptr(&timer_bases[BASE_STD]); 1824 1825 __run_timers(base); 1826 if (IS_ENABLED(CONFIG_NO_HZ_COMMON)) { 1827 __run_timers(this_cpu_ptr(&timer_bases[BASE_DEF])); 1828 #ifdef CONFIG_SMP > 1829 if ((atomic_cmpxchg(&deferrable_pending, 1, 0) && 1830 tick_do_timer_cpu == TICK_DO_TIMER_NONE) || 1831 tick_do_timer_cpu == smp_processor_id()) 1832 __run_timers(&timer_base_deferrable); 1833 #endif 1834 } 1835 } 1836
--- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org [unhandled content-type:application/gzip] | |