Messages in this thread | | | Subject | Re: [PATCH] sh: Implement __get_user_u64() required for 64-bit get_user() | From | John Paul Adrian Glaubitz <> | Date | Sun, 31 May 2020 11:54:37 +0200 |
| |
Hi Geert!
On 5/31/20 11:52 AM, Geert Uytterhoeven wrote: > As this is the 64-bit variant, I think this single move should be > replaced by a double move: > > "mov #0,%R1\n\t" \ > "mov #0,%S1\n\t" \ > > Same for the big endian version below. > > Disclaimer: uncompiled, untested, no SH assembler expert.
Right, this makes sense. I'll send a new patch shortly.
As for the assembler review, I'll ask Yutaka Niibe who is a friend of mine and one of the original SuperH wizards ;).
Adrian
-- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaubitz@debian.org `. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
| |