| From | Namhyung Kim <> | Date | Sun, 31 May 2020 14:52:23 +0900 | Subject | Re: [PATCH 03/19] perf ftrace: select function/function_graph tracer automatically |
| |
Hello,
On Mon, May 11, 2020 at 12:07 AM Changbin Du <changbin.du@gmail.com> wrote: > > The '-g/-G' options have already implied function_graph tracer should be > used instead of function tracer. So the extra option '--tracer' can be > killed. > > This patch changes the behavior as below: > - By default, function tracer is used.
Why? You also removed -t/--tracer option.
> - If '-g' or '-G' option is on, then function_graph tracer is used.
I'm ok with this.
> - The perf configuration item 'ftrace.tracer' is removed.
Why?
> - The default filter for -G is to trace all functions.
There's no reason to use -G option then. Also It might be confusing if it sees an argument - whether it's a function or a workload.
I just don't know why you want to change this as we have a way to change the default tracer already.
Thanks
Namhyung
|