Messages in this thread | | | Subject | Re: [PATCH] kernel: power: swap: mark a function as __init to save some memory | From | Joe Perches <> | Date | Sun, 31 May 2020 15:11:27 -0700 |
| |
(adding Dan Carpenter)
On Sun, 2020-05-31 at 23:00 +0200, Christophe JAILLET wrote: > 'swsusp_header_init()' is only called via 'core_initcall'. > It can be marked as __init to save a few bytes of memory.
Hey Dan
smatch has a full function calling tree right?
Can smatch find unmarked functions called only by __init functions so those unmarked functions can be appropriately marked with __init like the below?
> --- > kernel/power/swap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/power/swap.c b/kernel/power/swap.c > index ca0fcb5ced71..01e2858b5fe3 100644 > --- a/kernel/power/swap.c > +++ b/kernel/power/swap.c > @@ -1590,7 +1590,7 @@ int swsusp_unmark(void) > } > #endif > > -static int swsusp_header_init(void) > +static int __init swsusp_header_init(void) > { > swsusp_header = (struct swsusp_header*) __get_free_page(GFP_KERNEL); > if (!swsusp_header)
| |