Messages in this thread |  | | Date | Sat, 30 May 2020 21:43:37 -0700 (PDT) | Subject | Re: [PATCH] net: qrtr: Allocate workqueue before kernel_bind | From | David Miller <> |
| |
From: Chris Lew <clew@codeaurora.org> Date: Thu, 28 May 2020 16:05:26 -0700
> A null pointer dereference in qrtr_ns_data_ready() is seen if a client > opens a qrtr socket before qrtr_ns_init() can bind to the control port. > When the control port is bound, the ENETRESET error will be broadcasted > and clients will close their sockets. This results in DEL_CLIENT > packets being sent to the ns and qrtr_ns_data_ready() being called > without the workqueue being allocated. > > Allocate the workqueue before setting sk_data_ready and binding to the > control port. This ensures that the work and workqueue structs are > allocated and initialized before qrtr_ns_data_ready can be called. > > Fixes: 0c2204a4ad71 ("net: qrtr: Migrate nameservice to kernel from userspace") > Signed-off-by: Chris Lew <clew@codeaurora.org>
Applied, thank you.
|  |