Messages in this thread | | | Subject | Re: [PATCH 01/12] xen/manage: keep track of the on-going suspend mode | From | Boris Ostrovsky <> | Date | Sat, 30 May 2020 18:26:32 -0400 |
| |
On 5/19/20 7:24 PM, Anchal Agarwal wrote: > > +enum suspend_modes { > + NO_SUSPEND = 0, > + XEN_SUSPEND, > + PM_SUSPEND, > + PM_HIBERNATION, > +}; > + > +/* Protected by pm_mutex */ > +static enum suspend_modes suspend_mode = NO_SUSPEND; > + > +bool xen_suspend_mode_is_xen_suspend(void) > +{ > + return suspend_mode == XEN_SUSPEND; > +} > + > +bool xen_suspend_mode_is_pm_suspend(void) > +{ > + return suspend_mode == PM_SUSPEND; > +} > + > +bool xen_suspend_mode_is_pm_hibernation(void) > +{ > + return suspend_mode == PM_HIBERNATION; > +} > +
I don't see these last two used anywhere. Are you, in fact, distinguishing between PM suspend and hibernation?
(I would also probably shorten the name a bit, perhaps xen_is_pv/pm_suspend()?)
-boris
| |