lkml.org 
[lkml]   [2020]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 8/9] x86: kvm_hv_set_msr(): use __put_user() instead of 32bit __clear_user()
    On Sat, May 30, 2020 at 11:52:44AM -0700, Linus Torvalds wrote:

    > And I don't understand why you mention set_fs() vs access_ok(). None
    > of this code has anything that messes with set_fs(). The access_ok()
    > is garbage and shouldn't exist, and those user accesses should all use
    > the checking versions and the double underscores are wrong.
    >
    > I have no idea why you think the double underscores could _possibly_
    > be worth defending.

    I do not. What I'm saying is that this just might be a beast different
    from *both* __... and the normal ones. I'm not saying that this
    __put_user() (or __clear_user(), etc.) is the right primitive here.
    If anything, it's closer to the situation for (x86) copy_stack_trace().

    \
     
     \ /
      Last update: 2020-05-30 21:21    [W:8.809 / U:0.472 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site