lkml.org 
[lkml]   [2020]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 04/10] power: separate PageHighMem() and PageHighMemZone() use case
2020년 5월 1일 (금) 오후 9:22, Christoph Hellwig <hch@infradead.org>님이 작성:
>
> On Wed, Apr 29, 2020 at 12:26:37PM +0900, js1304@gmail.com wrote:
> > index 6598001..be759a6 100644
> > --- a/kernel/power/snapshot.c
> > +++ b/kernel/power/snapshot.c
> > @@ -1227,7 +1227,7 @@ static struct page *saveable_highmem_page(struct zone *zone, unsigned long pfn)
> > if (!page || page_zone(page) != zone)
> > return NULL;
> >
> > - BUG_ON(!PageHighMem(page));
> > + BUG_ON(!PageHighMemZone(page));
>
> The above check already checks for the highmem zone. So if we want
> to keep the BUG_ON it needs stay PageHighMem to make sense. That being
> said I'd rather remove it entirelẏ.

Okay.

> > - BUG_ON(PageHighMem(page));
> > + BUG_ON(PageHighMemZone(page));
>
> Same here.

Okay.

Thanks.

\
 
 \ /
  Last update: 2020-05-04 05:02    [W:0.115 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site