lkml.org 
[lkml]   [2020]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] nfp: abm: Fix incomplete release of system resources in nfp_abm_vnic_set_mac()
From
Date
> … Thus add a call of the function
> “nfp_nsp_close” for the completion of the exception handling.

Thanks for your positive response.

I imagined that a small patch series would be more reasonable
than this direct change combination.



> +++ b/drivers/net/ethernet/netronome/nfp/abm/main.c

> ether_addr_copy(nn->dp.netdev->perm_addr, mac_addr);
> +
> +generate_random_address:
> + eth_hw_addr_random(nn->dp.netdev);
> + return;
> }


Unfortunately, you interpreted my update suggestion in a questionable way
at this source code place.
I guess that the following code variant can be considered instead.

ether_addr_copy(nn->dp.netdev->perm_addr, mac_addr);
+ return;
+
+generate_random_address:
+ eth_hw_addr_random(nn->dp.netdev);
}


Regards,
Markus

\
 
 \ /
  Last update: 2020-05-03 22:26    [W:0.043 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site