lkml.org 
[lkml]   [2020]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v23 02/16] leds: multicolor: Introduce a multicolor class definition
From
Date
Jacek

On 5/2/20 4:51 PM, Jacek Anaszewski wrote:
> Dan,
>
> I've converted drivers/leds/leds-an30259a.c to LED mc framework
> and tested it on Samsung Galaxy S3 (exysnos4412-trats2 board).
> Works as expected. And now the framework usability is indeed neater.
>
> One thing to improve: LED mc based drivers' entries in Kconfig should
> have this dependency:
>
> depends on LEDS_CLASS_MULTI_COLOR || !LEDS_CLASS_MULTI_COLOR
>
> It is required to enforce building driver as a module if
> LED mc framework is configured as such.
>
Do you think the FLASH class needs this as well?  If so I will send this
in a separate patch


> With this (and DT bindings nits) addressed, for patches 1-6:
>
> Acked-by: Jacek Anaszewski <jacek.anaszewski@gmail.com>
>
Ack
> It's been a long journey. Thank you for your determination to drive
> this work to the end.
>
Ack to that.

Dan


\
 
 \ /
  Last update: 2020-05-03 14:35    [W:0.044 / U:2.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site