Messages in this thread | | | Date | Fri, 29 May 2020 09:51:53 -0700 | From | Guenter Roeck <> | Subject | Re: [PATCH] watchdog: sunxi_wdt: fix improper error exit code |
| |
On Fri, May 29, 2020 at 05:45:14PM +0800, Frank Lee wrote: > From: Martin Wu <wuyan@allwinnertech.com> > > sunxi_wdt_probe() should return -ENOMEM when devm_kzalloc() fails. > > Signed-off-by: Martin Wu <wuyan@allwinnertech.com> > Signed-off-by: Frank Lee <frank@allwinnertech.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> --- > drivers/watchdog/sunxi_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/sunxi_wdt.c b/drivers/watchdog/sunxi_wdt.c > index 5f05a45ac187..b50757882a98 100644 > --- a/drivers/watchdog/sunxi_wdt.c > +++ b/drivers/watchdog/sunxi_wdt.c > @@ -235,7 +235,7 @@ static int sunxi_wdt_probe(struct platform_device *pdev) > > sunxi_wdt = devm_kzalloc(dev, sizeof(*sunxi_wdt), GFP_KERNEL); > if (!sunxi_wdt) > - return -EINVAL; > + return -ENOMEM; > > sunxi_wdt->wdt_regs = of_device_get_match_data(dev); > if (!sunxi_wdt->wdt_regs) > -- > 2.24.0 >
| |