Messages in this thread | | | Date | Fri, 29 May 2020 18:28:50 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 1/2] arm64: dts: Add a device tree for the Librem5 phone |
| |
Hi!
> From: "Angus Ainslie (Purism)" <angus@akkea.ca> > > Add a devicetree description for the Librem 5 phone. The early batches > that have been sold are supported as well as the mass-produced device > available later this year, see https://puri.sm/products/librem-5/ > > This boots to a working console with working WWAN modem, wifi usdhc, > IMU sensor device, proximity sensor, haptic motor, gpio keys, GNSS and LEDs. > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca> > Signed-off-by: Guido Günther <agx@sigxcpu.org>
> + blue { > + label = "phone:blue:front"; > + label = "phone:green:front"; > + label = "phone:red:front";
Droid 4 uses "status-led:{red,green,blue}". Could this use same naming?
> + label = "lm3560:flash"; > + label = "lm3560:torch";
This is one LED, right? I'm pretty sure we don't want lm3560 in the name... "main-camera:flash" would be better. Even better would be something that's already in use.
> + label = "white:backlight_cluster";
Make this ":backlight", please. Again, we want something that's already used.
Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |