Messages in this thread | | | Subject | Re: [PATCH v2] blkdev: Replace blksize_bits() with ilog2() | From | Jens Axboe <> | Date | Fri, 29 May 2020 08:13:34 -0600 |
| |
On 5/29/20 8:11 AM, Kaitao Cheng wrote: > There is a function named ilog2() exist which can replace blksize. > The generated code will be shorter and more efficient on some > architecture, such as arm64. And ilog2() can be optimized according > to different architecture.
When you posted this last time, I said:
"I like the simplification, but do you have any results to back up that claim? Is the generated code shorter? Runs faster?"
which you handily ignored, yet sending out a new version. I'm not going to apply this without justification, your commit message is handwavy at best.
-- Jens Axboe
| |