lkml.org 
[lkml]   [2020]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] scsi: Fix reference count leak in iscsi_boot_create_kobj()
From
Date
> kobject_init_and_add() should be handled when it return an error,
> because kobject_init_and_add() takes reference even when it fails.

I find this wording approach improvable.


> Previous commit "b8eb718348b8" fixed a similar problem.

I suggest to omit this information from the commit message.


> Thus replace calling kfree() by calling kobject_put().

How do you think about a wording variant like the following?

Thus replace a call of the function “kfree” by “kobject_put”
because of using kernel objects in the proper way.


Please take another look also at the message field “To”.
Which recipients should be specified there first?

Regards,
Markus

\
 
 \ /
  Last update: 2020-05-29 12:11    [W:0.016 / U:3.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site