lkml.org 
[lkml]   [2020]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] edac: Fix reference count leak in edac_device_register_sysfs_main_kobj()
On Fri, May 29, 2020 at 10:45:08AM +0200, Markus Elfring wrote:
> Would you like to indicate with such information (according to
> the topic “net-sysfs: Fix reference count leak in rx|netdev_queue_add_kobject”)
> that your issue was detected also with the help of the kernel fuzzing
> tool “syzkaller”?

There's no need for any commt reference - there's text over
kobject_init_and_add() explaining what you need to do when that function
fails.

> How do you think about to add an imperative wording to the change description?

His commit message is fine.

> Will it be helpful to combine this update step together with
> “edac: Fix reference count leak in edac_pci_main_kobj_setup”
> into a small patch series?

Just combine them into one patch.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette

\
 
 \ /
  Last update: 2020-05-29 11:08    [W:0.094 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site