[lkml]   [2020]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH V2 0/4] x86/entry: simply stack switching when exception on userspace
7f2590a110b8("x86/entry/64: Use a per-CPU trampoline stack for IDT entries")
has resulted that when exception on userspace, the kernel (error_entry)
always push the pt_regs to entry stack(sp0), and then copy them to the
kernel stack.

And recent x86/entry work makes interrupt also use idtentry
and makes all the interrupt code save the pt_regs on the sp0 stack
and then copy it to the thread stack like exception.

This is hot path (page fault, ipi), such overhead should be avoided.
And the original interrupt_entry directly switches to kernel stack
and pushes pt_regs to kernel stack. We should do it for error_entry.
This is the job of patch1.

Patch 2-4 simply stack switching for .Lerror_bad_iret by just doing
all the work in one function (fixup_bad_iret()).

The patch set is based on tip/x86/entry (28447ea41542) (May 20).

Changed from V1:
based on tip/master -> based on tip/x86/entry

patch 1 replaces the patch1,2 of V1, it borrows the
original interrupt_entry's code into error_entry.

patch2-4 is V1's patch3-5, unchanged (but rebased)

Cc: Andy Lutomirski <>,
Cc: Thomas Gleixner <>,
Cc: Ingo Molnar <>,
Cc: Borislav Petkov <>,
Cc: "H. Peter Anvin" <>,
Cc: Peter Zijlstra <>,
Cc: Alexandre Chartre <>,
Cc: "Eric W. Biederman" <>,
Cc: Jann Horn <>,
Cc: Dave Hansen <>

Lai Jiangshan (4):
x86/entry: avoid calling into sync_regs() when entering from userspace
x86/entry: directly switch to kernel stack when .Lerror_bad_iret
x86/entry: remove unused sync_regs()
x86/entry: don't copy to tmp in fixup_bad_iret

arch/x86/entry/entry_64.S | 52 +++++++++++++++++++++++-------------
arch/x86/include/asm/traps.h | 1 -
arch/x86/kernel/traps.c | 42 ++++++++++++-----------------
3 files changed, 51 insertions(+), 44 deletions(-)


 \ /
  Last update: 2020-05-29 10:26    [W:0.303 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site