Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH] powerpc/nvram: Replace kmalloc with kzalloc in the error message | Date | Fri, 29 May 2020 14:04:01 +1000 |
| |
Yi Wang <wang.yi59@zte.com.cn> writes: > From: Liao Pingfang <liao.pingfang@zte.com.cn> > > Use kzalloc instead of kmalloc in the error message according to > the previous kzalloc() call.
Please just remove the message instead, it's a tiny allocation that's unlikely to ever fail, and the caller will print an error anyway.
cheers
> diff --git a/arch/powerpc/kernel/nvram_64.c b/arch/powerpc/kernel/nvram_64.c > index fb4f610..c3a0c8d 100644 > --- a/arch/powerpc/kernel/nvram_64.c > +++ b/arch/powerpc/kernel/nvram_64.c > @@ -892,7 +892,7 @@ loff_t __init nvram_create_partition(const char *name, int sig, > /* Create our OS partition */ > new_part = kzalloc(sizeof(*new_part), GFP_KERNEL); > if (!new_part) { > - pr_err("%s: kmalloc failed\n", __func__); > + pr_err("%s: kzalloc failed\n", __func__); > return -ENOMEM; > } > > -- > 2.9.5
| |