lkml.org 
[lkml]   [2020]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 9/9] staging: media: atomisp: add PMIC_OPREGION dependency
    On Fri, May 29, 2020 at 10:00:31PM +0200, Arnd Bergmann wrote:
    > Without that driver, there is a link failure in
    >
    > ERROR: modpost: "intel_soc_pmic_exec_mipi_pmic_seq_element"
    > [drivers/staging/media/atomisp/pci/atomisp_gmin_platform.ko] undefined!
    >
    > Add an explicit Kconfig dependency.
    >
    > Signed-off-by: Arnd Bergmann <arnd@arndb.de>

    It'd be interesting to know if this is strictly required for the driver
    to work properly. The call to intel_soc_pmic_exec_mipi_pmic_seq_element
    has some error handling after it, maybe that should just be surrounded
    by an #ifdef or IS_ENABLED for PMIC_OPREGION, like some other drivers
    do.

    Regardless of that:

    Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>

    > ---
    > drivers/staging/media/atomisp/Kconfig | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/staging/media/atomisp/Kconfig b/drivers/staging/media/atomisp/Kconfig
    > index c4f3049b0706..e86311c14329 100644
    > --- a/drivers/staging/media/atomisp/Kconfig
    > +++ b/drivers/staging/media/atomisp/Kconfig
    > @@ -11,6 +11,7 @@ menuconfig INTEL_ATOMISP
    > config VIDEO_ATOMISP
    > tristate "Intel Atom Image Signal Processor Driver"
    > depends on VIDEO_V4L2 && INTEL_ATOMISP
    > + depends on PMIC_OPREGION
    > select IOSF_MBI
    > select VIDEOBUF_VMALLOC
    > ---help---
    > --
    > 2.26.2
    >

    \
     
     \ /
      Last update: 2020-05-30 05:12    [W:4.190 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site