lkml.org 
[lkml]   [2020]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH][next] RDMA/hns: remove duplicate assignment to pointer raq
From
Date


在 2020/5/28 23:04, Colin King 写道:
> From: Colin Ian King <colin.king@canonical.com>
>
> The pointer raq is being assigned twice. Fix this by removing
> one of the redundant assignments.
>
> Fixes: 14ba87304bf9 ("RDMA/hns: Remove redundant type cast for general pointers")
> Addressses-Coverity: ("Evaluation order violation")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> index 8ff6b922b4d7..d02207cd30df 100644
> --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
> @@ -1146,7 +1146,7 @@ static void hns_roce_db_free(struct hns_roce_dev *hr_dev)
> static int hns_roce_raq_init(struct hns_roce_dev *hr_dev)
> {
> struct hns_roce_v1_priv *priv = hr_dev->priv;
> - struct hns_roce_raq_table *raq = raq = &priv->raq_table;
> + struct hns_roce_raq_table *raq = &priv->raq_table;
> struct device *dev = &hr_dev->pdev->dev;
> int raq_shift = 0;
> dma_addr_t addr;
>
thanks

\
 
 \ /
  Last update: 2020-05-29 09:27    [W:0.049 / U:1.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site