Messages in this thread | | | From | Peter Chen <> | Subject | RE: [PATCH] usb: gadget: f_acm: don't disable disabled EP | Date | Sat, 30 May 2020 01:03:17 +0000 |
| |
> > > @@ -425,9 +425,11 @@ static int acm_set_alt(struct usb_function *f, unsigned > intf, unsigned alt) > > > /* we know alt == 0, so this is an activation or a reset */ > > > > > > if (intf == acm->ctrl_id) { > > > - dev_vdbg(&cdev->gadget->dev, > > > - "reset acm control interface %d\n", intf); > > > - usb_ep_disable(acm->notify); > > > + if (acm->notify->enabled) { > > > + dev_vdbg(&cdev->gadget->dev, > > > + "reset acm control interface %d\n", intf); > > > + usb_ep_disable(acm->notify); > > > + } > > > > But it does not fix any issues, the usb_ep_disable checks 'enabled' flag. > > It generates spurious trace events if you enable them. >
You mean the trace events from core.c? If it is, we could try to improve it and indicate it is already enabled or disabled.
Peter
| |