lkml.org 
[lkml]   [2020]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] lan743x: Added fixed link and RGMII support
On Fri, May 29, 2020 at 09:30:02PM +0200, Roelof Berg wrote:
> Microchip lan7431 is frequently connected to a phy. However, it
> can also be directly connected to a MII remote peer without
> any phy in between. For supporting such a phyless hardware setup
> in Linux we utilized phylib, which supports a fixed-link
> configuration via the device tree. And we added support for
> defining the connection type R/GMII in the device tree.
>
> New behavior:
> -------------
> . The automatic speed and duplex detection of the lan743x silicon
> between mac and phy is disabled. Instead phylib is used like in
> other typical Linux drivers. The usage of phylib allows to
> specify fixed-link parameters in the device tree.
>
> . The device tree entry phy-connection-type is supported now with
> the modes RGMII or (G)MII (default).
>
> Development state:
> ------------------
> . Tested with fixed-phy configurations. Not yet tested in normal
> configurations with phy. Microchip kindly offered testing
> as soon as the Corona measures allow this.
>
> . All review findings of Andrew Lunn are included
>
> Example:
> --------
> &pcie {
> status = "okay";
>
> host@0 {
> reg = <0 0 0 0 0>;
>
> #address-cells = <3>;
> #size-cells = <2>;
>
> ethernet@0 {
> compatible = "weyland-yutani,noscom1", "microchip,lan743x";
> status = "okay";
> reg = <0 0 0 0 0>;
> phy-connection-type = "rgmii";
>
> fixed-link {
> speed = <100>;
> full-duplex;
> };
> };
> };
> };
>
> Signed-off-by: Roelof Berg <rberg@berg-solutions.de>

Hi Roelof

It looks like you took my suggestion as a basis. So i should give you:

Signed-off-by: Andrew Lunn <andrew@lunn.ch>

since i did not include one in my posting. I'm happy to see it helped,
and fixed some other issues you were seeing.

Andrew

\
 
 \ /
  Last update: 2020-05-29 23:31    [W:0.138 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site