[lkml]   [2020]   [May]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] ARM: omap2: fix omap5_realtime_timer_init definition
On Fri, May 29, 2020 at 10:44 PM Tony Lindgren <> wrote:
> * Arnd Bergmann <> [200529 20:18]:
> > There is one more regression introduced by the last build fix:
> Argh.. I did run make randconfig for like 10 builds
> after the last fix.
> > Address this by removing the now obsolete #ifdefs in that file and
> > just building the entire file based on the flag that controls the
> > omap5_realtime_timer_init function declaration.
> I think this will introduce other randconfig build failures
> as SOC_HAS_REALTIME_COUNTER is bool in Kconfig.

I did a few hundred randconfig builds with the patch and have
not yet seen any further problems.

> We still need to call omap5_realtime_timer_init() even if

This is what's in the header file:

extern void omap5_realtime_timer_init(void);
static inline void omap5_realtime_timer_init(void)

In fact, the inline stub is what that caused the regression,
so I think it's ok with my patch.


 \ /
  Last update: 2020-05-29 23:09    [W:0.060 / U:0.636 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site