Messages in this thread | | | Date | Fri, 29 May 2020 13:44:04 -0700 | From | Tony Lindgren <> | Subject | Re: [PATCH] ARM: omap2: fix omap5_realtime_timer_init definition |
| |
* Arnd Bergmann <arnd@arndb.de> [200529 20:18]: > There is one more regression introduced by the last build fix:
Argh.. I did run make randconfig for like 10 builds after the last fix.
> arch/arm/mach-omap2/timer.c:170:6: error: attribute declaration must precede definition [-Werror,-Wignored-attributes] > void __init omap5_realtime_timer_init(void) > ^ > arch/arm/mach-omap2/common.h:118:20: note: previous definition is here > static inline void omap5_realtime_timer_init(void) > ^ > arch/arm/mach-omap2/timer.c:170:13: error: redefinition of 'omap5_realtime_timer_init' > void __init omap5_realtime_timer_init(void) > ^ > arch/arm/mach-omap2/common.h:118:20: note: previous definition is here > static inline void omap5_realtime_timer_init(void) > > Address this by removing the now obsolete #ifdefs in that file and > just building the entire file based on the flag that controls the > omap5_realtime_timer_init function declaration.
I think this will introduce other randconfig build failures as SOC_HAS_REALTIME_COUNTER is bool in Kconfig.
We still need to call omap5_realtime_timer_init() even if SOC_HAS_REALTIME_COUNTER is not set.
Regards,
Tony
| |