Messages in this thread | | | Date | Wed, 27 May 2020 23:13:53 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH 02/10] iommu/amd: Unexport get_dev_data() |
| |
On Wed, May 27, 2020 at 01:53:05PM +0200, Joerg Roedel wrote: > From: Joerg Roedel <jroedel@suse.de> > > This function is internal to the AMD IOMMU driver and only exported > because the amd_iommu_v2 modules calls it. But the reason it is called > from there could better be handled by amd_iommu_is_attach_deferred(). > So unexport get_dev_data() and use amd_iommu_is_attach_deferred() > instead.
Btw, what is the reason amd_iommu_v2 is a separate module? It is very little code, and other drivers seem to just integrate such functionality.
| |