Messages in this thread | | | Date | Thu, 28 May 2020 17:42:57 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v3 05/10] dmaengine: Introduce DMA-device device_caps callback |
| |
On Wed, May 27, 2020 at 01:50:16AM +0300, Serge Semin wrote: > There are DMA devices (like ours version of Synopsys DW DMAC) which have > DMA capabilities non-uniformly redistributed amongst the device channels. > In order to provide a way of exposing the channel-specific parameters to > the DMA engine consumers, we introduce a new DMA-device callback. In case > if provided it gets called from the dma_get_slave_caps() method and is > able to override the generic DMA-device capabilities.
> + if (device->device_caps) > + device->device_caps(chan, caps); > + > return 0;
I dunno why this returns int, but either we get rid of this returned value (perhaps in the future, b/c it's not directly related to this series), or something like
if (device->device_caps) return device->device_caps(chan, caps);
-- With Best Regards, Andy Shevchenko
| |