lkml.org 
[lkml]   [2020]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 01/15] drm/panfrost: avoid static declaration
    From
    Date
    On 10/05/2020 17:55, Clément Péron wrote:
    > This declaration can be avoided so change it.
    >
    > Signed-off-by: Clément Péron <peron.clem@gmail.com>

    Reviewed-by: Steven Price <steven.price@arm.com>

    > ---
    > drivers/gpu/drm/panfrost/panfrost_devfreq.c | 38 ++++++++++-----------
    > 1 file changed, 18 insertions(+), 20 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
    > index 413987038fbf..1b560b903ea6 100644
    > --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c
    > +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
    > @@ -14,7 +14,24 @@
    > #include "panfrost_gpu.h"
    > #include "panfrost_regs.h"
    >
    > -static void panfrost_devfreq_update_utilization(struct panfrost_device *pfdev);
    > +static void panfrost_devfreq_update_utilization(struct panfrost_device *pfdev)
    > +{
    > + ktime_t now;
    > + ktime_t last;
    > +
    > + if (!pfdev->devfreq.devfreq)
    > + return;
    > +
    > + now = ktime_get();
    > + last = pfdev->devfreq.time_last_update;
    > +
    > + if (atomic_read(&pfdev->devfreq.busy_count) > 0)
    > + pfdev->devfreq.busy_time += ktime_sub(now, last);
    > + else
    > + pfdev->devfreq.idle_time += ktime_sub(now, last);
    > +
    > + pfdev->devfreq.time_last_update = now;
    > +}
    >
    > static int panfrost_devfreq_target(struct device *dev, unsigned long *freq,
    > u32 flags)
    > @@ -139,25 +156,6 @@ void panfrost_devfreq_suspend(struct panfrost_device *pfdev)
    > devfreq_suspend_device(pfdev->devfreq.devfreq);
    > }
    >
    > -static void panfrost_devfreq_update_utilization(struct panfrost_device *pfdev)
    > -{
    > - ktime_t now;
    > - ktime_t last;
    > -
    > - if (!pfdev->devfreq.devfreq)
    > - return;
    > -
    > - now = ktime_get();
    > - last = pfdev->devfreq.time_last_update;
    > -
    > - if (atomic_read(&pfdev->devfreq.busy_count) > 0)
    > - pfdev->devfreq.busy_time += ktime_sub(now, last);
    > - else
    > - pfdev->devfreq.idle_time += ktime_sub(now, last);
    > -
    > - pfdev->devfreq.time_last_update = now;
    > -}
    > -
    > void panfrost_devfreq_record_busy(struct panfrost_device *pfdev)
    > {
    > panfrost_devfreq_update_utilization(pfdev);
    >

    \
     
     \ /
      Last update: 2020-05-28 15:22    [W:4.379 / U:0.540 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site