lkml.org 
[lkml]   [2020]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.4 25/26] net/mlx4_core: fix a memory leak bug.
    Date
    From: Qiushi Wu <wu000273@umn.edu>

    [ Upstream commit febfd9d3c7f74063e8e630b15413ca91b567f963 ]

    In function mlx4_opreq_action(), pointer "mailbox" is not released,
    when mlx4_cmd_box() return and error, causing a memory leak bug.
    Fix this issue by going to "out" label, mlx4_free_cmd_mailbox() can
    free this pointer.

    Fixes: fe6f700d6cbb ("net/mlx4_core: Respond to operation request by firmware")
    Signed-off-by: Qiushi Wu <wu000273@umn.edu>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c
    index 6e501af0e532..f6ff9620a137 100644
    --- a/drivers/net/ethernet/mellanox/mlx4/fw.c
    +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c
    @@ -2734,7 +2734,7 @@ void mlx4_opreq_action(struct work_struct *work)
    if (err) {
    mlx4_err(dev, "Failed to retrieve required operation: %d\n",
    err);
    - return;
    + goto out;
    }
    MLX4_GET(modifier, outbox, GET_OP_REQ_MODIFIER_OFFSET);
    MLX4_GET(token, outbox, GET_OP_REQ_TOKEN_OFFSET);
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-05-28 14:04    [W:3.830 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site