Messages in this thread | | | Date | Thu, 28 May 2020 12:42:45 +0100 | From | Mark Brown <> | Subject | Re: [v2] ASoC: AMD: Use mixer control to switch between DMICs |
| |
On Thu, May 28, 2020 at 11:32:30AM +0530, Akshu Agrawal wrote:
> @@ -307,6 +295,7 @@ static const struct snd_kcontrol_new acp3x_mc_controls[] = { > SOC_DAPM_PIN_SWITCH("Headphone Jack"), > SOC_DAPM_PIN_SWITCH("Spk"), > SOC_DAPM_PIN_SWITCH("Headset Mic"), > + SOC_SINGLE_BOOL_EXT("DMIC Switch", 0, dmic_get, dmic_set),
This now looks like a mute for the DMIC which is not accurate. I really do think this would be better as a mux, rather than labelling it with positions on the case you could follow what other drivers do and label it with the connections on the device. [unhandled content-type:application/pgp-signature] | |