Messages in this thread | | | From | Arnd Bergmann <> | Date | Thu, 28 May 2020 12:25:49 +0200 | Subject | Re: [PATCH 1/5] power: vexpress: add suppress_bind_attrs to true |
| |
On Wed, May 27, 2020 at 3:27 PM Rob Herring <robh@kernel.org> wrote: > > On Wed, May 27, 2020 at 5:26 AM Anders Roxell <anders.roxell@linaro.org> wrote: > > > > Make sure that the POWER_RESET_VEXPRESS driver won't have bind/unbind > > attributes available via the sysfs, so lets be explicit here and use > > ".suppress_bind_attrs = true" to prevent userspace from doing something > > silly. > > This doesn't really make sense if we're going to make this a module. > Module unloading and unbind introduce the same requirements of > cleaning up (undoing whatever probe did).
I still want this change as a separate patch so we can backport it to stable kernels for correctness.
Also, as long as we don't have a working (and tested) .remove callback, we can only allow making the driver a loadable module but not also allowing the module to be removed.
Arnd
| |