lkml.org 
[lkml]   [2020]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [git pull] coredump infoleak fix

    * Al Viro <viro@zeniv.linux.org.uk> wrote:

    > On Thu, May 28, 2020 at 09:02:55AM +0200, Ingo Molnar wrote:
    >
    > > Looks good to me.
    > >
    > > I'm wondering, shouldn't we also zero-initialize the dump data to
    > > begin with? See the patch below (untested).
    >
    > Note that this hides the bug from KASAN, though ;-) And the bug
    > is not just infoleak - not all components are "all zeroes" in the
    > init state.

    Yeah, but is zero-init really a problem though? Wouldn't it be
    'better' to have all zeroes if the dump doesn't fit? But I might be
    missing something ...

    Thanks,

    Ingo

    \
     
     \ /
      Last update: 2020-05-28 09:44    [W:2.715 / U:0.228 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site