lkml.org 
[lkml]   [2020]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/2] esas2r: don't bother with __copy_to_user()
    Date
    From: Al Viro <viro@zeniv.linux.org.uk>

    sure, we'd done copy_from_user() on the same range, so we can
    skip access_ok()... and it's not worth bothering. Just use
    copy_to_user().

    Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
    ---
    drivers/scsi/esas2r/esas2r_ioctl.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/scsi/esas2r/esas2r_ioctl.c b/drivers/scsi/esas2r/esas2r_ioctl.c
    index 442c5e70a7b4..cc620f10eabc 100644
    --- a/drivers/scsi/esas2r/esas2r_ioctl.c
    +++ b/drivers/scsi/esas2r/esas2r_ioctl.c
    @@ -1510,7 +1510,7 @@ int esas2r_ioctl_handler(void *hostdata, unsigned int cmd, void __user *arg)
    }

    /* Always copy the buffer back, if only to pick up the status */
    - err = __copy_to_user(arg, ioctl, sizeof(struct atto_express_ioctl));
    + err = copy_to_user(arg, ioctl, sizeof(struct atto_express_ioctl));
    if (err != 0) {
    esas2r_log(ESAS2R_LOG_WARN,
    "ioctl_handler copy_to_user didn't copy everything (err %d, cmd %u)",
    --
    2.11.0
    \
     
     \ /
      Last update: 2020-05-29 02:06    [W:4.585 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site