Messages in this thread | | | Subject | Re: [v1] drm/msm: add shutdown support for display platform_driver | From | Stephen Boyd <> | Date | Thu, 28 May 2020 15:20:18 -0700 |
| |
Quoting Krishna Manikandan (2020-05-28 01:38:23) > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c > index e4b750b..7a8953f 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -1322,6 +1322,18 @@ static int msm_pdev_remove(struct platform_device *pdev) > return 0; > } > > +static void msm_pdev_shutdown(struct platform_device *pdev) > +{ > + struct drm_device *drm = platform_get_drvdata(pdev); > + > + if (!drm) { > + DRM_ERROR("Invalid drm device node\n"); > + return; > + }
When would this ever happen? Please drop this useless check.
> + > + drm_atomic_helper_shutdown(drm); > +} > + > static const struct of_device_id dt_match[] = { > { .compatible = "qcom,mdp4", .data = (void *)KMS_MDP4 }, > { .compatible = "qcom,mdss", .data = (void *)KMS_MDP5 },
| |