Messages in this thread | | | Subject | Re: [PATCH v4 10/10] cacheinfo: Move resctrl's get_cache_id() to the cacheinfo header file | From | Reinette Chatre <> | Date | Thu, 28 May 2020 13:46:32 -0700 |
| |
Hi James,
On 5/26/2020 6:40 AM, James Morse wrote: > resctrl/core.c defines get_cache_id() for use in its cpu-hotplug > callbacks. This gets the id attribute of the cache at the corresponding > level of a cpu. > > Later rework means this private function needs to be shared. Move > it to the header file. > > The name conflicts with a different definition in intel_cacheinfo.c, > name it get_cpu_cacheinfo_id() to show its relation with > get_cpu_cacheinfo(). > > Now this is visible on other architectures, check the id attribute > has actually been set. > > Signed-off-by: James Morse <james.morse@arm.com> > Reviewed-by: Babu Moger <babu.moger@amd.com> > ---
Moving this out of resctrl seems appropriate, thank you.
For the resctrl portions: Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reinette
| |