[lkml]   [2020]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 02/12] net: hns3: Destroy a mutex after initialisation failure in hclge_init_ad_dev()
> Add a mutex destroy call in hclge_init_ae_dev() when fails.

How do you think about a wording variant like the following?

Change description:
The function “mutex_init” was called before a call of
the function “hclge_pci_init”.
But the function “mutex_destroy” was not called after initialisation
steps failed.
Thus add the missed function call for the completion of
the exception handling.

Would you like to add the tag “Fixes” to the commit message?

> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
> @@ -10108,6 +10108,7 @@ static int hclge_init_ae_dev(struct hnae3_ae_dev *ae_dev)
> pci_release_regions(pdev);
> pci_disable_device(pdev);
> out:
> + mutex_destroy(&hdev->vport_lock);
> return ret;
> }

How do you think about to use the label “destroy_mutex” instead?


 \ /
  Last update: 2020-05-28 20:46    [W:0.056 / U:0.980 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site