Messages in this thread | | | Date | Thu, 28 May 2020 10:53:53 -0700 | From | "Darrick J. Wong" <> | Subject | Re: [PATCH 09/12] xfs: flag files as supporting buffered async reads |
| |
On Tue, May 26, 2020 at 01:51:20PM -0600, Jens Axboe wrote: > XFS uses generic_file_read_iter(), which already supports this. > > Signed-off-by: Jens Axboe <axboe@kernel.dk>
Er... I guess that looks ok? Assuming you've done enough qa on io_uring to be able to tell if this breaks anything, since touching the mm always feels murky to me:
Acked-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> --- > fs/xfs/xfs_file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c > index 4b8bdecc3863..97f44fbf17f2 100644 > --- a/fs/xfs/xfs_file.c > +++ b/fs/xfs/xfs_file.c > @@ -1080,7 +1080,7 @@ xfs_file_open( > return -EFBIG; > if (XFS_FORCED_SHUTDOWN(XFS_M(inode->i_sb))) > return -EIO; > - file->f_mode |= FMODE_NOWAIT; > + file->f_mode |= FMODE_NOWAIT | FMODE_BUF_RASYNC; > return 0; > } > > -- > 2.26.2 >
| |