Messages in this thread Patch in this message | | | Date | Thu, 28 May 2020 19:07:38 +0200 | From | "" <> | Subject | Re: [PATCH -next] power: supply: Make bd9995x_chip_reset static |
| |
Hi,
On Mon, May 11, 2020 at 11:22:26AM +0000, Vaittinen, Matti wrote: > On Mon, 2020-05-11 at 19:12 +0800, Samuel Zou wrote: > > Fix the following sparse warning: > > > > drivers/power/supply/bd99954-charger.c:1028:6: warning: symbol > > 'bd9995x_chip_reset' was not declared. > > > > The bd9995x_chip_reset() has only one call site within bd99954- > > charger.c > > It should be static > > > > Fixes: 0902f8366491 ("power: supply: Support ROHM bd99954 charger") > > Reported-by: Hulk Robot <hulkci@huawei.com> > > Signed-off-by: Samuel Zou <zou_wei@huawei.com> > > Reviewed-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Thanks, queued.
-- Sebastian
> > --- > > drivers/power/supply/bd99954-charger.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/power/supply/bd99954-charger.c > > b/drivers/power/supply/bd99954-charger.c > > index 3da39c7..ffd8bfa 100644 > > --- a/drivers/power/supply/bd99954-charger.c > > +++ b/drivers/power/supply/bd99954-charger.c > > @@ -1025,7 +1025,7 @@ static int bd9995x_fw_probe(struct > > bd9995x_device *bd) > > return 0; > > } > > > > -void bd9995x_chip_reset(void *bd) > > +static void bd9995x_chip_reset(void *bd) > > { > > __bd9995x_chip_reset(bd); > > } > [unhandled content-type:application/pgp-signature] | |