Messages in this thread Patch in this message | | | Subject | Re: [PATCH v2 1/3] scsi: ufs: remove max_t in ufs_get_device_desc | From | Bart Van Assche <> | Date | Thu, 28 May 2020 09:16:01 -0700 |
| |
On 2020-05-28 08:04, Bean Huo wrote: > do you mean like this: buff_len = hba->desc_size[id]?
How about the following untested change?
Thanks,
Bart.
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 698e8d20b4ba..e33754c15c2c 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -6606,14 +6606,11 @@ static int ufshcd_scsi_add_wlus(struct ufs_hba static int ufs_get_device_desc(struct ufs_hba *hba) { int err; - size_t buff_len; u8 model_index; u8 *desc_buf; struct ufs_dev_info *dev_info = &hba->dev_info;
- buff_len = max_t(size_t, hba->desc_size.dev_desc, - QUERY_DESC_MAX_SIZE + 1); - desc_buf = kmalloc(buff_len, GFP_KERNEL); + desc_buf = kmalloc(QUERY_DESC_MAX_SIZE, GFP_KERNEL); if (!desc_buf) { err = -ENOMEM; goto out;
| |