Messages in this thread | | | From | Andrey Konovalov <> | Date | Thu, 28 May 2020 17:24:43 +0200 | Subject | Re: [PATCH 2/3] kasan: move kasan_report() into report.c |
| |
On Thu, May 28, 2020 at 5:15 PM Qian Cai <cai@lca.pw> wrote: > > On Thu, May 28, 2020 at 05:00:54PM +0200, 'Andrey Konovalov' via kasan-dev wrote: > > On Thu, May 28, 2020 at 3:49 PM Qian Cai <cai@lca.pw> wrote: > > > > > > On Tue, May 12, 2020 at 05:33:20PM +0200, 'Andrey Konovalov' via kasan-dev wrote: > > > > The kasan_report() functions belongs to report.c, as it's a common > > > > functions that does error reporting. > > > > > > > > Reported-by: Leon Romanovsky <leon@kernel.org> > > > > Signed-off-by: Andrey Konovalov <andreyknvl@google.com> > > > > > > Today's linux-next produced this with Clang 11. > > > > > > mm/kasan/report.o: warning: objtool: kasan_report()+0x8a: call to __stack_chk_fail() with UACCESS enabled > > > > > > kasan_report at mm/kasan/report.c:536 > > > > Hm, the first patch in the series ("kasan: consistently disable > > debugging features") disables stack protector for kasan files. Is that > > patch in linux-next? > > Yes, it is there, > > +CFLAGS_report.o := $(call cc-option, -fno-conserve-stack -fno-stack-protector) > > It seems that will not work for Clang?
Ah, Clang doesn't have -fno-conserve-stack and that makes the whole cc-option expression fail? OK, I'll send a fix.
| |