Messages in this thread | | | From | "Kleen, Andi" <> | Subject | RE: [PATCH 0/3] make vm_committed_as_batch aware of vm overcommit policy | Date | Thu, 28 May 2020 15:21:36 +0000 |
| |
>If it's true, then there could be 2 solutions, one is to skip the WARN_ONCE as it has no practical value, as the real >check is the following code, the other is to rectify the percpu counter when the policy is changing to >OVERCOMMIT_NEVER.
I think it's better to fix it up when the policy changes. That's the right place. The WARN_ON might be useful to catch other bugs.
-Andi
| |