Messages in this thread | | | Date | Wed, 27 May 2020 11:52:35 +0200 | From | Pablo Neira Ayuso <> | Subject | Re: [PATCH net] netfilter: conntrack: Pass value of ctinfo to __nf_conntrack_update |
| |
On Wed, May 27, 2020 at 01:10:39AM -0700, Nathan Chancellor wrote: > Clang warns: > > net/netfilter/nf_conntrack_core.c:2068:21: warning: variable 'ctinfo' is > uninitialized when used here [-Wuninitialized] > nf_ct_set(skb, ct, ctinfo); > ^~~~~~ > net/netfilter/nf_conntrack_core.c:2024:2: note: variable 'ctinfo' is > declared here > enum ip_conntrack_info ctinfo; > ^ > 1 warning generated. > > nf_conntrack_update was split up into nf_conntrack_update and > __nf_conntrack_update, where the assignment of ctifno is in > nf_conntrack_update but it is used in __nf_conntrack_update. > > Pass the value of ctinfo from nf_conntrack_update to > __nf_conntrack_update so that uninitialized memory is not used > and everything works properly.
Applied, thanks.
| |