Messages in this thread | | | Date | Tue, 26 May 2020 22:09:22 -0700 | From | Christoph Hellwig <> | Subject | Re: [PATCH v5 0/4] Charge loop device i/o to issuing cgroup |
| |
On Tue, May 26, 2020 at 10:28:03AM -0400, Dan Schatzberg wrote: > Will do - I'll split out the lock-use refactor into a separate > patch. Do you have particular concerns about re-using the existing > spinlock? Its existing use is not contended so I didn't see any harm > in extending its use. I'll add this justification to the commit > message as well, but I'm tempted to leave the re-use as is instead of > creating a new lock.
Please don't share a lock for entirely separate critical sections that are used from different contexts.
| |