lkml.org 
[lkml]   [2020]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] ASoC: img-spdif-out: Fix runtime PM imbalance on error
    Date
    pm_runtime_get_sync() increments the runtime PM usage counter even
    the call returns an error code. Thus a pairing decrement is needed
    on the error handling path to keep the counter balanced.

    Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
    ---
    sound/soc/img/img-spdif-out.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    diff --git a/sound/soc/img/img-spdif-out.c b/sound/soc/img/img-spdif-out.c
    index 456c462d52fb..b1d8e4535726 100644
    --- a/sound/soc/img/img-spdif-out.c
    +++ b/sound/soc/img/img-spdif-out.c
    @@ -370,8 +370,10 @@ static int img_spdif_out_probe(struct platform_device *pdev)
    goto err_pm_disable;
    }
    ret = pm_runtime_get_sync(&pdev->dev);
    - if (ret < 0)
    + if (ret < 0) {
    + pm_runtime_put_noidle(&pdev->dev);
    goto err_suspend;
    + }

    img_spdif_out_writel(spdif, IMG_SPDIF_OUT_CTL_FS_MASK,
    IMG_SPDIF_OUT_CTL);
    --
    2.17.1
    \
     
     \ /
      Last update: 2020-05-27 10:47    [W:3.124 / U:1.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site