Messages in this thread | | | Date | Wed, 27 May 2020 10:14:48 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] staging: rtl8712: Fix IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK |
| |
On Sat, May 23, 2020 at 10:12:47PM +0100, Pascal Terjan wrote: > The value in shared headers was fixed 9 years ago in commit 8d661f1e462d > ("ieee80211: correct IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK macro") and > while looking at using shared headers for other duplicated constants > I noticed this driver uses the old value. > > The macros are also defined twice in this file so I am deleting the > second definition. > > Signed-off-by: Pascal Terjan <pterjan@google.com> > Cc: stable <stable@vger.kernel.org> > --- > drivers/staging/rtl8712/wifi.h | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > > diff --git a/drivers/staging/rtl8712/wifi.h b/drivers/staging/rtl8712/wifi.h > index be731f1a2209..91b65731fcaa 100644 > --- a/drivers/staging/rtl8712/wifi.h > +++ b/drivers/staging/rtl8712/wifi.h > @@ -440,7 +440,7 @@ static inline unsigned char *get_hdr_bssid(unsigned char *pframe) > /* block-ack parameters */ > #define IEEE80211_ADDBA_PARAM_POLICY_MASK 0x0002 > #define IEEE80211_ADDBA_PARAM_TID_MASK 0x003C > -#define IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK 0xFFA0 > +#define IEEE80211_ADDBA_PARAM_BUF_SIZE_MASK 0xFFC0 > #define IEEE80211_DELBA_PARAM_TID_MASK 0xF000 > #define IEEE80211_DELBA_PARAM_INITIATOR_MASK 0x0800
I'll take this patch, but why can't this code be all deleted such that the real in-kernel defines are used instead of these duplicated ones?
thanks,
greg k-h
| |