lkml.org 
[lkml]   [2020]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v11 00/56] atmel_mxt_ts misc
    Hi Jiada,

    On Thu, May 07, 2020 at 10:56:00PM -0700, Jiada Wang wrote:
    > This patch-set forward ports Nick Dyer's work in ndyer/linux github
    > repository as long as some other features and fixes

    Sorry for ignoring the series for quite a while. I guess my biggest
    issue with the series is that quite a bit of patches are trying to
    handle the fallout from a very unfortunate design decision in the
    driver: the fact that it attempts to automatically upload firmware and
    config on every boot/probe. This design was done at my urging because I
    did not have access to the technical documentation and did not realize
    that the controller has non-volatile memory for both firmware and
    configuration. We should only attempt to automatically load firmware
    where device does not have non-volatile memory and is unable function
    otherwise, in all other cases we better leave it to userspace to decide
    whether to execute firmware update and when. The kernel should only
    provide facilities so that userspace can initiate firmware update. This
    design has worked well for Chrome OS for many years (it used Atmel
    controllers in several products), and I would like to bring it to the
    mainline.

    Thanks.

    --
    Dmitry

    \
     
     \ /
      Last update: 2020-05-27 08:44    [W:4.137 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site