Messages in this thread | | | From | Saeed Mahameed <> | Subject | Re: [PATCH] net/mlx5e: Don't use err uninitialized in mlx5e_attach_decap | Date | Wed, 27 May 2020 16:28:58 +0000 |
| |
On Wed, 2020-05-27 at 00:50 -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c:3712:6: warning: > variable 'err' is used uninitialized whenever 'if' condition is false > [-Wsometimes-uninitialized] > if (IS_ERR(d->pkt_reformat)) { > ^~~~~~~~~~~~~~~~~~~~~~~ > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c:3718:6: note: > uninitialized use occurs here > if (err) > ^~~ > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c:3712:2: note: remove > the > 'if' if its condition is always true > if (IS_ERR(d->pkt_reformat)) { > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c:3670:9: note: > initialize > the variable 'err' to silence this warning > int err; > ^ > = 0 > 1 warning generated. > > It is not wrong, err is only ever initialized in if statements but > this > one is not in one. Initialize err to 0 to fix this. > > Fixes: 14e6b038afa0 ("net/mlx5e: Add support for hw decapsulation of > MPLS over UDP") > Link: https://github.com/ClangBuiltLinux/linux/issues/1037 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > ---
Applied to net-next-mlx5, will send shortly to net-next
Thanks, Saeed.
| |