lkml.org 
[lkml]   [2020]   [May]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v9 08/10] dt-bindings: ufs: Add DT binding documentation for ufs
Date
Hi Rob,

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: 26 May 2020 23:39
> To: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: devicetree@vger.kernel.org; linux-scsi@vger.kernel.org;
krzk@kernel.org;
> avri.altman@wdc.com; martin.petersen@oracle.com;
> kwmad.kim@samsung.com; stanley.chu@mediatek.com;
> cang@codeaurora.org; linux-samsung-soc@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v9 08/10] dt-bindings: ufs: Add DT binding
documentation
> for ufs
>
> On Thu, May 14, 2020 at 06:09:12AM +0530, Alim Akhtar wrote:
> > This patch adds DT binding for samsung ufs hci
>
> Subject should indicate this is for Samsung in some way.
>
Sure will update the Subject as suggested by you.

> >
> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> > ---
> > .../bindings/ufs/samsung,exynos-ufs.yaml | 91 +++++++++++++++++++
> > 1 file changed, 91 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
> > b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
> > new file mode 100644
> > index 000000000000..eaa64cc32d52
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
> > @@ -0,0 +1,91 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2
> > +---
> > +$id:
> > +https://protect2.fireeye.com/url?k=9995443c-c4461d82-9994cf73-0cc47a3
> > +1ba82-
> 2c9d6322e4bc35a5&q=1&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2F
> > +ufs%2Fsamsung%2Cexynos-ufs.yaml%23
> > +$schema:
> > +https://protect2.fireeye.com/url?k=70bd56cd-2d6e0f73-70bcdd82-0cc47a3
> > +1ba82-7865215595a4146c&q=1&u=http%3A%2F%2Fdevicetree.org%2Fmeta-
> schem
> > +as%2Fcore.yaml%23
> > +
> > +title: Samsung SoC series UFS host controller Device Tree Bindings
> > +
> > +maintainers:
> > + - Alim Akhtar <alim.akhtar@samsung.com>
> > +
> > +description: |
> > + Each Samsung UFS host controller instance should have its own node.
> > + This binding define Samsung specific binding other then what is
> > +used
> > + in the common ufshcd bindings
> > + [1] Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
> > +
> > +properties:
> > +
> > + compatible:
> > + enum:
> > + - samsung,exynos7-ufs
> > +
> > + reg:
> > + items:
> > + - description: HCI register
> > + - description: vendor specific register
> > + - description: unipro register
> > + - description: UFS protector register
> > +
> > + reg-names:
> > + items:
> > + - const: hci
> > + - const: vs_hci
> > + - const: unipro
> > + - const: ufsp
> > +
> > + clocks:
> > + maxItems: 2
>
> maxItems is redundant.
>
Will drop it.

> > + items:
> > + - description: ufs link core clock
> > + - description: unipro main clock
> > +
> > + clock-names:
> > + maxItems: 2
>
> Here too.
Will drop it.
>
> > + items:
> > + - const: core_clk
> > + - const: sclk_unipro_main
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + phys:
> > + maxItems: 1
> > +
> > + phy-names:
> > + maxItems: 1
>
> What's the name? (Though a name is kind of pointless when there is only
> 1.)
Not sure are you suggesting to drop the phy-names completely? Or just keep
"phy-names:" only.
I looked into how other bindings has handle it, I will change this as
phy-names:
const: ufs-phy

Hope you are ok with this.

>
> With those fixed,
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
With adding "phy-names" entry, I will adds your Reviewed-by tag, will post
the updated changes soon.
Thank you!!

> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - phys
> > + - phy-names
> > + - clocks
> > + - clock-names
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/clock/exynos7-clk.h>
> > +
> > + ufs: ufs@15570000 {
> > + compatible = "samsung,exynos7-ufs";
> > + reg = <0x15570000 0x100>,
> > + <0x15570100 0x100>,
> > + <0x15571000 0x200>,
> > + <0x15572000 0x300>;
> > + reg-names = "hci", "vs_hci", "unipro", "ufsp";
> > + interrupts = <GIC_SPI 200 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&clock_fsys1 ACLK_UFS20_LINK>,
> > + <&clock_fsys1 SCLK_UFSUNIPRO20_USER>;
> > + clock-names = "core_clk", "sclk_unipro_main";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&ufs_rst_n &ufs_refclk_out>;
> > + phys = <&ufs_phy>;
> > + phy-names = "ufs-phy";
> > + };
> > +...
> > --
> > 2.17.1
> >

\
 
 \ /
  Last update: 2020-05-27 18:24    [W:0.056 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site