Messages in this thread | | | Date | Wed, 27 May 2020 18:55:33 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v5 06/11] i2c: designware: Add Baytrail sem config DW I2C platform dependency |
| |
On Wed, May 27, 2020 at 06:30:41PM +0300, Serge Semin wrote: > Currently Intel Baytrail I2C semaphore is a feature of the DW APB I2C > platform driver. It's a bit confusing to see it's config in the menu at > some separated place with no reference to the platform code. Let's move the > config definition to be below the I2C_DESIGNWARE_PLATFORM config and mark > it with "depends on I2C_DESIGNWARE_PLATFORM" statement. By doing so the > config menu will display the feature right below the DW I2C platform > driver item and will indent it to the right so signifying its belonging.
Same comment as per previous version.
> config I2C_DESIGNWARE_BAYTRAIL > bool "Intel Baytrail I2C semaphore support" > depends on ACPI > + depends on I2C_DESIGNWARE_PLATFORM > depends on (I2C_DESIGNWARE_PLATFORM=m && IOSF_MBI) || \ > (I2C_DESIGNWARE_PLATFORM=y && IOSF_MBI=y)
i.e. this change is not needed.
-- With Best Regards, Andy Shevchenko
| |